[tor-bugs] #18933 [Core Tor/Tor]: Several problems with test-network Makefile target

[Tor Bug Tracker & Wiki]

#18933: Several problems with test-network Makefile target
--------------------------------------------+------------------------------
 Reporter:  isis                            |          Owner:  cypherpunks
     Type:  defect                          |         Status:  assigned
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:  Tor:
 Severity:  Normal                          |  0.2.8.2-alpha
 Keywords:  TorCoreTeam201605 029-proposed  |     Resolution:
Parent ID:                                  |  Actual Points:
 Reviewer:  nickm                           |         Points:  small
                                            |        Sponsor:  SponsorS
--------------------------------------------+------------------------------

Comment (by cypherpunks):

 The test-network target also has the problem of not finding the path to
 Chutney when Tor is built out-of-tree. The `need-chutney-path` target can
 find it but that's only because it knows the source directory. Using the
 `--tor-path` option for specifying the source directory should make test-
 network.sh able to correctly detect Chutney. I'll make a patch for this.

 Comparing the checks in test-network.sh and `need-chutney-path` shows lots
 of duplication so I'm thinking about removing the `need-chutney-path`
 target altogether. Unless there is a specific use-case for it that i am
 unaware of.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18933#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online