[tor-bugs] #18460 [Tor]: Relays and bridges are not counting directory requests coming in via IPv6

[Tor Bug Tracker & Wiki]

#18460: Relays and bridges are not counting directory requests coming in via IPv6
-------------------------------------------------+-------------------------
 Reporter:  karsten                              |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  tor-relay tor-bridge 026-backport    |        Version:  Tor:
  027-backport                                   |  0.2.8.1-alpha
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Okay, I implemented the fix that I suggested above in
 [https://gitweb.torproject.org/karsten/tor.git/log/?h=task-18460-2 branch
 task-18460-2 in my public repository].  It works just fine in Chutney
 networks with IPv4 and IPv6 bridge clients.

 I also included a changes file.  For the "bugfix on" part, I found 4aca55e
 where we started counting IPv6 connections in bridge and entry stats,
 shortly followed by 4741aa4 which partially reverted that change and put
 back some code that only works for IPv4.  I'd say that 4741aa4 is to blame
 here, so I'm using the first release containing that commit in the "bugfix
 on" part.

 Should we test this patch on an IPv6 bridge before merging it?  When
 looking at extra-info descriptors from the past 72 hours, the following
 bridges show a non-zero number of IPv6 clients: antirio, starman,
 MeekGoogle.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18460#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online