[tor-bugs] #13252 [Tor Browser]: Tor Browser on OS X should not store data into the application bundle

[Tor Bug Tracker & Wiki]

#13252: Tor Browser on OS X should not store data into the application bundle
-----------------------------------+------------------------------
 Reporter:  torosx                 |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #6540                  |         Points:
 Reviewer:                         |        Sponsor:  None
-----------------------------------+------------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review


Comment:

 Kathy and I created a couple of fix up patches to cause data to be placed
 under ~/Library/Application Support/TorBrowser-Data when appropriate. The
 Tor Launcher one is fairly simple:

 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug13252-fixup-01&id=c4d03f9b16b625f11a08fe0f6dfc5ed6b2467638

 And the browser patch is here:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug13252-fixup-01&id=673d1ba99ad5992a5838b808764a8b0ee4fd1056

 Note that we refactored the code to reduce redundancy and added a
 TorBrowser_GetUserDataDir() function. Also, the diffs for
 nsXREDirProvider::GetUpdateRootDir() are somewhat large because it made
 more sense to revert that function to the original Mozilla code and then
 modify it to use the new function. We also realized that on Mac OS we
 should add the application path under the UpdateInfo directory on because
 that directory may be shared across different copies of the app (this is
 especially likely when the data is under ~/Library/Application Support).

 Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13252#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online