[tor-bugs] #18616 [Tor]: Bug: Node search initiated by. Stack trace:

[Tor Bug Tracker & Wiki]

#18616: Bug: Node search initiated by. Stack trace:
------------------------------------------------+--------------------------
 Reporter:  toralf                              |          Owner:
     Type:  defect                              |         Status:
 Priority:  Medium                              |  needs_review
Component:  Tor                                 |      Milestone:  Tor:
 Severity:  Normal                              |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc  |        Version:  Tor:
Parent ID:                                      |  0.2.8.1-alpha
 Reviewer:                                      |     Resolution:
                                                |  Actual Points:
                                                |         Points:
                                                |        Sponsor:
------------------------------------------------+--------------------------

Comment (by nickm):

 I'm not so sure about whether this patch.
 router_should_be_directory_server has been used to decide whether we
 should _advertise_ directory support, not whether we should _provide_ it.
 It also has side-effects of changing the 'advertising' static variable.

 Should the check become, looking at the last-returned value from
 router_should_be_directory_server, rather than recalculating it?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online