[tor-bugs] #13252 [Tor Browser]: Tor Browser on OS X should not store data into the application bundle

[Tor Bug Tracker & Wiki]

#13252: Tor Browser on OS X should not store data into the application bundle
-----------------------------------+------------------------------
 Reporter:  torosx                 |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #6540                  |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by gk):

 The tor-launcher changes look good to me. Some minor things:

 1) regarding the changes in the prefs.js: s/tor_path pref./tor_path/ like
 you did for the other paths?

 2) I wonder whether
 {{{
 // In FF21+, CurProcD is the "browser" directory that is next to
 // the firefox binary, e.g., <TorFileBaseDir>/Browser/browser
 }}}
 should be in the Tor Browser code path (as it basically was before). I was
 confused to read that comment and then the code continued to be concerned
 with Thunderbird/Instantbird

 2) What is the reason for treating `torrc-defaults` differently here, i.e.
 moving that one out of the data dir?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13252#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online