[tor-bugs] #13252 [Tor Browser]: Tor Browser on OS X should not store data into the application bundle

[Tor Bug Tracker & Wiki]

#13252: Tor Browser on OS X should not store data into the application bundle
-----------------------------------+------------------------------
 Reporter:  torosx                 |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #6540                  |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:27 gk]:
 > Comments to the tor-browser-bundle changes:
 >
 > 1) It seems to me we can get rid of creating `Caches` altogether without
 the need for treating that step specially in the non-signed bundles? I
 tested it a bit and `Caches` seems to get created anyway.

 Yes, you are correct that we can just let the browser create it when it is
 opened for the first time. Do you want us to make that change (skip
 creation of the Caches directory) for all platforms at this time or just
 for Mac OS?

 > 2) Could you add the FTE ticket number in the FTE TODO comment?

 Sure; good idea.

 > 3) The second `rm -rf $SKELETON_TMP` seems wrong to me as we are still
 in the directory we want to delete. And we already delete it before we
 begin with our skeleton preparation. Maybe a copy/paste fail?

 I think it should just be moved after the cd -, not removed. The idea is
 to clean up the directory now that its contents have been captured inside
 inputs/mac-skeleton.zip.

 > 4) Do we have some alternative for handling the bookmarks file? Putting
 it into the `omni.ja` file seems a bit weird to me.

 When Firefox creates a new profile, it copies the default bookmarks from
 defaults/profile/bookmarks.html within browser/omni.ja. In other words, we
 are using the standard mechanism that Firefox uses to get our bookmarks
 into new profiles. We could have replaced
 browser/locales/generic/profile/bookmarks.html.in with our own content
 inside the tor-browser repo (via a Firefox patch) but since (1) our
 bookmarks are already part of tor-browser-bundle and (2) we already touch
 browser/omni.ja to modify the 000-tor-browser.js, we thought it best to
 handle the bookmarks in a similar way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13252#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online