[tor-bugs] #18466 [Tor Browser]: Fix torbutton for ESR45 (was: Fix domain-isolator for ESR45)

[Tor Bug Tracker & Wiki]

#18466: Fix torbutton for ESR45
-----------------------------------+------------------------------
 Reporter:  arthuredelstein        |          Owner:  tbb-team
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #15197                 |         Points:
  Sponsor:                         |
-----------------------------------+------------------------------
Description changed by arthuredelstein:

Old description:

> domain-isolator.js has a couple of minor breakages in Firefox 45.
>
> 1. A new ReferenceError is thrown by things like `let mozilla = mozilla
> || {};`. We can change it to `let mozilla = {};`.
>
> 2. The method `newSOCKSProxyInfo` was available in our SOCKS proxy patch.
> Since we landed that patch with some minor changes, we should now make an
> equivalent call to built-in Firefox method `newProxyInfoWithAuth`.

New description:

 domain-isolator.js has a couple of minor breakages in Firefox 45.

 1. A new ReferenceError is thrown by things like `let mozilla = mozilla ||
 {};`. We can change it to `let mozilla = {};`.

 2. The method `newSOCKSProxyInfo` was available in our SOCKS proxy patch.
 Since we landed that patch with some minor changes, we should now make an
 equivalent call to built-in Firefox method `newProxyInfoWithAuth`.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18466#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online