[tor-bugs] #18454 [Tor]: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from src/common/address.c:1668 with a non-IP address of type 11829

[Tor Bug Tracker & Wiki]

#18454: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from
src/common/address.c:1668 with a non-IP address of type 11829
-------------------------------+------------------------------------
 Reporter:  toralf             |          Owner:
     Type:  defect             |         Status:  new
 Priority:  Very High          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  memory-corruption  |  Actual Points:
Parent ID:                     |         Points:
  Sponsor:                     |
-------------------------------+------------------------------------

Comment (by teor):

 Thanks cypherpunks, toralf, we'll make sure we get that patch in
 0.2.8.2-alpha.

 As cypherpunks noted in [comment:4 cypherpunks], we should also avoid
 calling tor_free on potentially uninitialised memory in
 get_interface_addresses_ioctl. I think this should fix it:

 {{{
   struct ifconf ifc;
 +  /* Initialise ifc.ifc_buf to NULL, so that tor_free ignores it. */
 +  memset(ifc, 0, sizeof(ifc));
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18454#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online