[tor-bugs] #19273 [Applications/Tor Browser]: Write C++ patch to replace external applications helper dialog workaround

[Tor Bug Tracker & Wiki]

#19273: Write C++ patch to replace external applications helper dialog workaround
--------------------------------------+------------------------------
 Reporter:  gk                        |          Owner:  mcs
     Type:  task                      |         Status:  needs_review
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201606R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:  SponsorU
--------------------------------------+------------------------------
Changes (by mcs):

 * cc: arthuredelstein (added)
 * keywords:  TorBrowserTeam201606 => TorBrowserTeam201606R
 * status:  assigned => needs_review


Comment:

 Here is a tor-browser patch that generates "external-app-requested"
 observer service notifications that Torbutton can use to prompt and
 optionally cancel the launch of an external application:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19273-01&id=0dff6c74126b5b52d4d7504644365af30985042b

 and here is a Torbutton patch that uses the new notification (and removes
 a lot of old JS code):
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19273-01&id=d9ce9236ab4e2d371426e9e25d16e804ed5b2332

 Please review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19273#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online