[tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jun 27 16:08:03 UTC 2016
#19259: uncaught NFE
-----------------------------+-----------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: needs_information
Priority: High | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Major | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+-----------------------------------
Comment (by iwakeh):
That was the information I was intending to elicit :-) Thanks!
Just a few things left:
> How about we represent missing values on disk as empty string (`""`),
which also saves disk space, and in memory as `-1.0` to keep the current
code working?
>
I still would prefer Double.NaN (cf. comment:9) as being more obvious in
code/in memory.
On disk it could be the empty string even though not very nice, but it's
used already anyway.
> > `testCompare` fails, b/c there is an entry with the key from the first
and values from the second element.
>
> Let's reject those lines, too.
It's not that easy here; the test demonstrates would could happen b/c of
the
comparator not being compatible with equal.
So the missing part is an ordering for the intervals. The only one I can
think
of is the lexicographical ordering according to interval ends, e.g.,
[10, 20] before [10, 21] before [12, 25]. That should capture the intend
of
the current approach?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19259#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list