[tor-bugs] #19454 [Core Tor/Tor]: tor crashed when "HeartbeatPeriod 0"

[Tor Bug Tracker & Wiki]

#19454: tor crashed when "HeartbeatPeriod 0"
----------------------------+------------------------------------
 Reporter:  kukabu          |          Owner:
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor    |        Version:  Tor: 0.2.8.4-rc
 Severity:  Blocker         |     Resolution:
 Keywords:  review-group-4  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  asn             |        Sponsor:
----------------------------+------------------------------------

Comment (by asn):

 Ah, I also removed this XXX that was saying:
 {{{
 -  /* XXXX This isn't such a good way to handle possible changes in the
 -   * callback event */
 }}}

 I'm not sure exactly what was referring to and I thought it was referring
 to this bug we just fixed, but maybe we should put the XXX back in?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19454#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online