[tor-bugs] #19454 [Core Tor/Tor]: tor crashed when "HeartbeatPeriod 0"

[Tor Bug Tracker & Wiki]

#19454: tor crashed when "HeartbeatPeriod 0"
--------------------------+------------------------------------
 Reporter:  kukabu        |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.8.4-rc
 Severity:  Blocker       |     Resolution:
 Keywords:  029-proposed  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:5 kukabu]:
 > cypherpunks, similar code already exists
 >
 > https://gitweb.torproject.org/tor.git/tree/src/or/config.c#n3357
 That is only for checking whether the option (if enabled aka not zero)
 isn't lower than `MIN_HEARTBEAT_PERIOD`. My patch changes the callback
 function to do nothing when heartbeats are disabled (aka HeartbeatPeriod
 is zero).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19454#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online