[tor-bugs] #18693 [Core Tor/Tor]: New SOCKS port restriction to only allow connections to .onion

[Tor Bug Tracker & Wiki]

#18693: New SOCKS port restriction to only allow connections to .onion
---------------------------+------------------------------------
 Reporter:  ioerror        |          Owner:  teor
     Type:  enhancement    |         Status:  needs_information
 Priority:  Very Low       |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  tor-hs, socks  |  Actual Points:  .5
Parent ID:                 |         Points:  .5
 Reviewer:  special        |        Sponsor:  SponsorR-can
---------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_information


Comment:

 Ok I jumped on this one so we can move it forward for 029. The code is
 good! I've rebased it on master and fixed special's comment in fixup
 commit `c39110f`.

 I've also added two extra fixup commits for minor syntax issues in
 comments. I've tested all options and it works fine.

 Although, I would really want an explanation for commit `a6f8fe9` (like
 special mentioned). Why is this a fix all of a sudden? Maybe we can
 improve the comment there telling us _why_ we do that?

 Branch: `ticket18693_029_01`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18693#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online