[tor-bugs] #19220 [Core Tor/Tor]: Do not override Makefile user variables

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Jun 11 14:34:08 UTC 2016


#19220: Do not override Makefile user variables
--------------------------+---------------------
 Reporter:  cypherpunks   |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Low           |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  gcc-warnings  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+---------------------
Changes (by nickm):

 * keywords:   => gcc-warnings


Comment:

 Sounds like a good idea to me, but we watch out: there's actually a couple
 of cases where that approach won't work.  In any case where the warning
 triggers on the default autoconf test program, we'll get a false negative
 given the way that our CHECK_CFLAGS macro works now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19220#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list