[tor-bugs] #19379 [Core Tor/Tor]: Consider adding even more compiler warnings, even when they require code changes.

[Tor Bug Tracker & Wiki]

#19379: Consider adding even more compiler warnings, even when they require code
changes.
------------------------------+--------------------------
     Reporter:  nickm         |      Owner:
         Type:  enhancement   |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  parent        |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 Some of these warnings _might_ be worth adding, either globally or
 selectively, but they would require a significant amount of effort to
 modify our code.   (I already got the easy cases with #19180, I think.)

 {{{
   cast-qual (4.6)

     Rationale: triggers everywhere, even in some pretty normal C.  Would
     be nice to have it trigger less, but would need to blow up a bunch
     of API things.  Bigger project.

   conversion (4.6)

     Rationale: triggers all over.  Probably wrong code in some
     cases, but careful thought needed in most Bigger project.

   sign-conversion (4.6)

     Triggers ALL OVER.  Quite possibly a bug in some cases, though.
     Bigger project.

   cast-align (3)
     We already do this safely. Need to re-test on a system with
     stronger-than-intel alignment rules, though.

   shadow (3)
     mistake; worth fixing.

   switch-default (3)
    Not sure this is a good idea; someof these look like mistakes,
    but some don't.

   assign-enum (clang)
    triggers all over; worth fixing.

   conditional-uninitialized (clang)
    triggers all over; not sure whether this is worth fixing.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19379>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online