[tor-bugs] #15395 [Metrics/Atlas]: add support for more than 40 results

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jun 10 19:20:49 UTC 2016


#15395: add support for more than 40 results
----------------------------------------------+----------------------------
 Reporter:  cypherpunks                       |          Owner:  phw
     Type:  defect                            |         Status:
 Priority:  Medium                            |  needs_review
Component:  Metrics/Atlas                     |      Milestone:
 Severity:  Normal                            |        Version:
 Keywords:  complete-before-abandoning-globe  |     Resolution:
Parent ID:                                    |  Actual Points:
 Reviewer:                                    |         Points:
                                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by irl):

 {{{
 <% if (relays.length >= 40) {%>
 }}}

 Should this actually ever happen? I mean, == 40 is fine, but at most 40
 relays will be returned so if more than 40 are returned something has gone
 horribly wrong.

 {{{
 <% if (i > 40) return true; %>
 }}}

 Again here, if this code path is ever followed, then there is an error
 occuring in your changes in results.js and at best we're disguising the
 error.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15395#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list