[tor-bugs] #19639 [Core Tor/Tor]: Make sure extend_info_from_router is only called on servers

[Tor Bug Tracker & Wiki]

#19639: Make sure extend_info_from_router is only called on servers
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_revision
Component:  Core Tor/Tor                     |      Milestone:  Tor:
 Severity:  Normal                           |  0.2.9.x-final
 Keywords:  029-proposed, CoreTorTeam201607  |        Version:  Tor:
Parent ID:                                   |  0.2.8.1-alpha
 Reviewer:  nickm                            |     Resolution:
                                             |  Actual Points:  0.1
                                             |         Points:  0.1
                                             |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm
 * milestone:  Tor: 0.3.0.x-final => Tor: 0.2.9.x-final


Comment:

 Actual-review-points: 0

 Two problems.
   * BUG is for use in conditionals.  In this context, use
 tor_assert_nonfatal.
   * router_skip_or_reachability is declared static in routerlist.c

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19639#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online