[tor-bugs] #8625 [Core Tor/Tor]: Do not call networkstatus_reset_download_failures() hourly

[Tor Bug Tracker & Wiki]

#8625: Do not call networkstatus_reset_download_failures() hourly
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  High                                 |  assigned
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-client 025-backport              |        Version:
  026-triaged-1 026-deferrable tor-dos           |     Resolution:
  TorCoreTeam201607                              |  Actual Points:
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------

Comment (by andrea):

 This one turns out to be easy to just disable the callback in
 {{{main.c}}}, and the result bootstraps and works correctly when the
 network is operating normally, but testing in situations where some
 failures and scheduled retries actually happen is more challenging; I
 could parse a list of all (IP:dirport) pairs out of the consensus for
 directory mirrors and use iptables to make all direct download attempts
 fail, but this will be incomplete given the ability to tunnel directory
 requests once bootstrapped.  Possibly this needs the introduction of a new
 config option to simulate failure of all download requests when enabled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8625#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online