[tor-bugs] #19566 [Core Tor/Tor]: SR: Use BUG() instead of tor_assert() when we can

[Tor Bug Tracker & Wiki]

#19566: SR: Use BUG() instead of tor_assert() when we can
------------------------------+---------------------------------
     Reporter:  dgoulet       |      Owner:
         Type:  enhancement   |     Status:  new
     Priority:  Low           |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Minor         |   Keywords:  tor-sr dirauth easy
Actual Points:                |  Parent ID:
       Points:  0.2           |   Reviewer:
      Sponsor:                |
------------------------------+---------------------------------
 Example:

 {{{
 tor_assert(sr_state_get_phase() == SR_PHASE_REVEAL);
 }}}

 Should be replaced by:
 {{{
 if (BUG(sr_state_get_phase() != SR_PHASE_REVEAL))
   return;
 }}}

 The idea is to not kill the dirauth if this happens but still scream very
 loudly. Few other places in the SR subsystem can be found.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19566>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online