[tor-bugs] #14881 [Tor]: incorrect defaults when producing bandwidth-weights line in directory footer
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Jan 29 00:25:01 UTC 2016
#14881: incorrect defaults when producing bandwidth-weights line in directory
footer
-------------------------------------------------+-------------------------
Reporter: robgjansen | Owner:
Type: defect | robgjansen
Priority: Medium | Status:
Component: Tor | needs_revision
Severity: Normal | Milestone: Tor:
Keywords: 027-triaged-1-in, 028-triaged, | 0.2.8.x-final
pre028-patch | Version: Tor:
Parent ID: | 0.2.7
Sponsor: SponsorU | Resolution:
| Actual Points:
| Points: medium
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:11 robgjansen]:
> What is requested of me here? Do I simply need to increment the a
consensus version counter somewhere, and add a blurb to the changelog, and
attach a new patch? Am I mistaken in thinking that these are trivial
additions? Or is there something complex that I am overlooking?
Adding a consensus method means:
* adding a `#define MIN_METHOD_FOR_INIT_BW_WEIGHTS_ONE 22`
* updating `#define MAX_SUPPORTED_CONSENSUS_METHOD 22`
* keep the old behaviour when `consensus_method <
MIN_METHOD_FOR_INIT_BW_WEIGHTS_ONE`, that is, the consensus method
supported by the majority of the authorities does not include the changes
* use the new behaviour when `consensus_method >=
MIN_METHOD_FOR_INIT_BW_WEIGHTS_ONE`
And then making sure that when we merge, each consensus method actually
gets a different number.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14881#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list