[tor-bugs] #17790 [Tor Browser]: unit tests for keyboard defenses

[Tor Bug Tracker & Wiki]

#17790: unit tests for keyboard defenses
-----------------------------------+------------------------------
 Reporter:  arthuredelstein        |          Owner:  tbb-team
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201601R  |  Actual Points:
Parent ID:                         |         Points:
  Sponsor:                         |
-----------------------------------+------------------------------
Changes (by gk):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 arthuredelstein]:
 > Replying to [comment:4 gk]:
 > > [...]
 >
 > All good comments and suggestions. I have made fixes to both patches to
 try to address all of these. Also, in writing the additional tests, I
 found a mistake in the KeyboardEvent patch, so I am including a fixup
 patch in this new branch:
 >
 > https://github.com/arthuredelstein/tor-browser/commits/17790+1
 >
 > There are three patches in total.

 I've taken the fixup for tbb-5.5. The tests need a closer look for which I
 don't have the time now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17790#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online