[tor-bugs] #9145 [Tor Browser]: Tor Browser for windows is borked because mingw, gcc, and Win32 ABI

[Tor Bug Tracker & Wiki]

#9145: Tor Browser for windows is borked because mingw, gcc, and Win32 ABI
-------------------------+--------------------------
 Reporter:  dope457      |          Owner:  tbb-team
     Type:  defect       |         Status:  new
 Priority:  High         |      Milestone:
Component:  Tor Browser  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  tbb-crash    |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+--------------------------

Comment (by cypherpunks):

 Any ideas why to hack
 [https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=blob;f=gcc/config/i386/i386.c;hb=HEAD#l7972
 classify_argument] would be wrong or useless?
 {{{
        if (bytes > 64)
         return 0;

 +      /* On MS-ABI we pass stuctures on the stack if C++. XXXXX check
 check */
 +      if ((enum tree_code) type->base.code == RECORD_TYPE)
 +        return 0;
 +
        for (i = 0; i < words; i++)
         classes[i] = X86_64_NO_CLASS;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9145#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online