[tor-bugs] #16943 [Tor]: Implement prop250 (Random Number Generation During Tor Voting)

[Tor Bug Tracker & Wiki]

#16943: Implement prop250 (Random Number Generation During Tor Voting)
-------------------------+------------------------------------
 Reporter:  asn          |          Owner:
     Type:  enhancement  |         Status:  needs_review
 Priority:  High         |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:  tor-hs       |  Actual Points:
Parent ID:  #8244        |         Points:  large
  Sponsor:  SponsorR     |
-------------------------+------------------------------------
Changes (by dgoulet):

 * priority:  Medium => High
 * status:  new => needs_review
 * type:  defect => enhancement
 * severity:  Blocker => Normal


Comment:

 Hello! asn and I are very happy to present to you wonderful reviewers the
 implementation for proposal 250 along with the final specification:

 Both branch in tor.git and torspec.git: `dgoulet/prop250_final_v1`

 Some notes. We've separated this in 7 commits prefixed with `prop250:`
 except first one that adds a needed `tor_htonll/ntohll` function to tor
 utils. This code is mostly contained in two *new* files (with their
 headers) that are `shared-random.{c|h}` and `shared-random-state.{c|h}`.

 Our unit test code coverage:
 {{{
     shared-random-state.c   92.8 %      376 / 405      65.3 %      109 /
 167
     shared-random.c         85.1 %      326 / 383      66.9 %      101 /
 151
 }}}

 Also, there are attacks to this protocol that we are well aware of but all
 are easily detectable so for this reason we've wrote a DocTor
 specification that atagar will help use deploy once this is merged.

 https://storm.torproject.org/shared/kXO7N2oatC9RzRcZvfLNVaA1yNkZ6m5rODGUYEt08H6

 Finally, we expect this code to run for a long time before the shared
 random values generated by the authorities are used thus for now you will
 NOT find anything using them.

 Please ask questions! This won't be that trivial to review :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16943#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online