[tor-bugs] #18022 [Tor bundles/installation]: start-tor-browser.desktop parameter passing broken on spaces

[Tor Bug Tracker & Wiki]

#18022: start-tor-browser.desktop parameter passing broken on spaces
------------------------------------------+-------------------
     Reporter:  adrelanos                 |      Owner:  erinn
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Tor bundles/installation  |    Version:
     Severity:  Normal                    |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |    Sponsor:
------------------------------------------+-------------------
 Steps to reproduce:

 1. install Tor Browser to /home/user/.tb/tor-browser (but any folder
 should work if you adjust the paths below)
 2. Go to https://check.torproject.org
 3. Save that website under /home/user/Downloads/
 4. There now will be a file "/home/user/Downloads/Congratulations. This
 browser is configured to use Tor..html" (any other long file name with
 spaces should work also)

 The following commands to work as expected:

 {{{
 bash -x /home/user/.tb/tor-browser/Browser/start-tor-browser --new-tab
 "/home/user/Downloads/Congratulations. This browser is configured to use
 Tor..html"
 }}}

 {{{
 bash -x /home/user/.tb/tor-browser/Browser/start-tor-browser
 "/home/user/Downloads/Congratulations. This browser is configured to use
 Tor..html"
 }}}

 {{{
 firefox "/home/user/Downloads/Congratulations. This browser is configured
 to use Tor..html"
 }}}

 The following fails:
 {{{
 /home/user/.tb/tor-browser/start-tor-browser.desktop
 "/home/user/Downloads/Congratulations. This browser is configured to use
 Tor..html"
 }}}

 Expected result:
 Open that file and show it in Tor Browser as the other above commands
 working for Firefox / Tor Browser should do.

 Actual result:
 Tor Browser opens ~ 10 links that do not work. To {{{Congratulations.}}},
 {{{This}}}, etc.

 Impact:
 This currently prevents Whonix users [Whonix is using Tor Browser by
 default] to open local html files.

 Workaround:
 We could use {{{Browser/start-tor-browser}}} directly instead, which would
 work, if that is now the canonical way to do this.

 But perhaps parameter passing can be fixed in start-tor-browser.desktop?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18022>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online