[tor-bugs] #17986 [Tor]: Use SecureZeroMemory in memwipe on Windows

[Tor Bug Tracker & Wiki]

#17986: Use SecureZeroMemory in memwipe on Windows
-------------------------+------------------------------------
 Reporter:  teor         |          Owner:
     Type:  enhancement  |         Status:  reopened
 Priority:  Medium       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor          |        Version:
 Severity:  Minor        |     Resolution:
 Keywords:  windows      |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+------------------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Jenkins says:
 {{{
 ../tor/src/common/crypto.c: In function 'memwipe':
 22:31:43 ../tor/src/common/crypto.c:2965:3: error: implicit declaration of
 function 'SecureZeroMemory' [-Werror=implicit-function-declaration]
 22:31:43 ../tor/src/common/crypto.c:2965:3: error: nested extern
 declaration of 'SecureZeroMemory' [-Werror=nested-externs]
 }}}
 https://jenkins.torproject.org/job/tor-ci-windows/1795/consoleFull

 Microsoft says we need to include Windows.h (which includes WinBase.h) to
 get this function.
 https://msdn.microsoft.com/en-us/library/windows/desktop/aa366877.aspx

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17986#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online