[tor-bugs] #17986 [Tor]: Use SecureZeroMemory for Wind

[Tor Bug Tracker & Wiki]

#17986: Use SecureZeroMemory for Wind
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
     Severity:  Minor        |   Keywords:  windows
Actual Points:               |  Parent ID:
       Points:               |    Sponsor:
-----------------------------+--------------------------------
 In #7419, we use explicit_bzero/memset_s in memwipe when available.

 Windows has SecureZeroMemory with the same semantics in Windows.h.
 ​https://msdn.microsoft.com/en-us/library/windows/desktop/aa366877.aspx

 As long as we build our Windows binaries with headers that contain
 SecureZeroMemory, the code will work on any Windows version:

 "This function is defined as the RtlSecureZeroMemory function (see
 WinBase.h). The implementation of RtlSecureZeroMemory is provided inline
 and can be used on any version of Windows (see WinNT.h.)"

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17986>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online