[tor-bugs] #17443 [Tor]: tor-gencert --passphrase-fd improperly checks for newline

[Tor Bug Tracker & Wiki]

#17443: tor-gencert --passphrase-fd improperly checks for newline
------------------------+------------------------------------
 Reporter:  junglefowl  |          Owner:
     Type:  defect      |         Status:  needs_review
 Priority:  Medium      |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor         |        Version:  Tor: 0.2.7.4-rc
 Severity:  Normal      |     Resolution:
 Keywords:  crash       |  Actual Points:
Parent ID:              |         Points:
  Sponsor:              |
------------------------+------------------------------------

Comment (by nickm):

 Not setting the length to zero; instead taking everything to the EOF.

 Initializing the buffer to zero.

 New version in branch 'bug17443_v2' ; how's that one?

 >What about the argument against limiting the passphrase as made in
 comment 2 or is that for another ticket?

 A few observations there:
    * Changing the semantics of tor-gencert could make existing scripts
 start acting differently.
    * The current semantics were meant for approximate compatibility with
 the semantics of the case where passphrase-fd wasn't given.
    * Nobody runs tor-gencert on windows; it's only for authorities.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17443#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online