[tor-bugs] #17682 [Tor]: safe_timer_diff is unsafe under wrapping

[Tor Bug Tracker & Wiki]

#17682: safe_timer_diff is unsafe under wrapping
------------------------------+------------------------------------
 Reporter:  teor              |          Owner:  nickm
     Type:  defect            |         Status:  closed
 Priority:  High              |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor               |        Version:  Tor: unspecified
 Severity:  Normal            |     Resolution:  fixed
 Keywords:  regression, easy  |  Actual Points:
Parent ID:  #17983            |         Points:  small
  Sponsor:                    |
------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Sounds like since time_t is never unsigned, and shadow starts at 0, we'll
 be fine.

 Also sounds like teor thought this would be okay so long as we checked
 that.

 Squashing and merging this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17682#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online