[tor-bugs] #18261 [Tor]: socket listening defer code segfaults when no user is set

[Tor Bug Tracker & Wiki]

#18261: socket listening defer code segfaults when no user is set
------------------------+--------------------------------
     Reporter:  weasel  |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:
    Component:  Tor     |    Version:  Tor: 0.2.8.1-alpha
     Severity:  Normal  |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------
 {{{
 <weasel> +    if (port->is_unix_addr && !geteuid() &&
 strcmp(options->User, "root"))
 <weasel> +      continue;
 <weasel> is options->User guaranteed to be set?
 }}}

 Nope, it's not, as nickm, arma, and weasel concur:
 Tor 0.2.8.1-alpha-dev (git-1f5cdf2b6c72ae89) died: Caught signal 11
 {{{
 #2  0x00007f2079b2994c in crash_handler (sig=<optimized out>,
 si=<optimized out>, ctx_=<optimized out>) at ../src/common/backtrace.c:144
 #3  <signal handler called>
 #4  0x00007f2079ada53e in retry_listener_ports
 (control_listeners_only=<optimized out>, new_conns=<optimized out>,
 ports=<optimized out>, old_conns=<optimized out>) at
 ../src/or/connection.c:2401
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18261>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online