[tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file

Tue Feb 2 13:56:06 UTC 2016

#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
---------------------------+----------------------------------
     Reporter:  propropus  |      Owner:
         Type:  defect     |     Status:  new
     Priority:  High       |  Milestone:
    Component:  Tor        |    Version:
     Severity:  Major      |   Keywords:  WarnUnsafeSocks, Log
Actual Points:             |  Parent ID:
       Points:             |    Sponsor:
---------------------------+----------------------------------
 The parameter WarnUnsafeSocks does not work as specified in the
 documentation, no warning is logged in the log file when a connection is
 done to an ip address.

 If WarnUnsafeSocks 1 (default) is set there is no warning in the log file.
 If you look at the code for log_unsafe_socks_warning, the only case where
 an error is logged is when safe_socks is true. safe_socks is true only
 when SafeSocks parameter is set, but not when WarnUnsafeSocks is set.

 The code should be

 if (safe_socks || options->WarnUnsafeSocks) {

 instead of

 if (safe_socks) {

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online