[tor-bugs] #20990 [Core Tor/Tor]: Turn on warnings in autotools

[Tor Bug Tracker & Wiki]

#20990: Turn on warnings in autotools
-----------------------------+------------------------------------
 Reporter:  cypherpunks      |          Owner:
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-14  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by nickm):

 But what if we take the approach in my branch `bug20990`?  It replaces
 your 'AM_PROG_AR' with:
 {{{
 +dnl check for the correct "ar" when cross-compiling.
 +dnl   (AM_PROG_AR was new in automake 1.11.2, which we do not yet
 require,
 +dnl    so kludge up a replacement for the case where it isn't there yet.)
 +m4_ifdef([AM_PROG_AR],
 +         [AM_PROG_AR],
 +        [AN_MAKEVAR([AR], [AC_PROG_AR])
 +          AN_PROGRAM([ar], [AC_PROG_AR])
 +          AC_DEFUN([AC_PROG_AR], [AC_CHECK_TOOL([AR], [ar], [ar])])
 +          AC_PROG_AR])
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20990#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online