[tor-bugs] #17605 [Core Tor/Tor]: Tell caches to remove X-Your-Address-Is from Tor Directory documents

[Tor Bug Tracker & Wiki]

#17605: Tell caches to remove X-Your-Address-Is from Tor Directory documents
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  jryans
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-auth, isaremoved,                |  Actual Points:
  tor-03-unspecified-201612                      |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by jryans):

 * status:  assigned => needs_review


Comment:

 My understanding from the discussion above is that we can:

 1. Remove the `X-Your-Address-Is` hint entirely
 2. Use `NETINFO` cells from remote nodes to detect IP address changes

 Here's a branch with those changes:

 https://github.com/torproject/tor/compare/master...jryans:rm-address-
 header

 I've used local testing with Chutney to verify that it's working
 correctly.

 We do appear to receive both IPv4 and IPv6 addresses as expected via
 `NETINFO` cells.  We should also update the control spec to note a new
 method for IP address changes, but I'll wait until we discuss the approach
 here first.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17605#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online