[tor-bugs] #21044 [Core Tor/Tor]: ORPort self reachability test happens also when it shouldn't

[Tor Bug Tracker & Wiki]

#21044: ORPort self reachability test happens also when it shouldn't
--------------------------+------------------------------------
 Reporter:  s7r           |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by s7r):

 Thinking again the protocol to guess `Address` is OK to be called even
 when `ORPort` is explicitly configured as a loopback or NAT address
 because there might be such setups. This is why there is a log message
 instructing about IP address mismatch and how to use `NoAdvertise` and
 `NoListen` flags along with `Address` to fix it.

 So, the first two behaviors (bypass the protocol to guess `Address` and
 bypass self reachability tests) should only happen when
 `PublishServerDescriptor 0` is set and `ORPort` is a loopback or NAT
 address, otherwise use the current behavior which is fine for cases where
 user wants to run a public relay / bridge.

 Also, there might be use cases where one does not want to publish the
 descriptor but uses a separate tool that does this or just needs to export
 the descriptor and use it somehow, so `PublishServerDescriptor 0` should
 build it, but not publish it as it currently does - we just need to
 correct the self reachability tests when this option is set.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21044#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online