[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Dec 21 19:00:46 UTC 2016
#20458: Integration tests should be run locally before committing code changes
----------------------------------------------+----------------------------
Reporter: chelseakomlo | Owner:
| chelseakomlo
Type: enhancement | Status: assigned
Priority: Medium | Milestone: Tor:
| 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: test, doc, triage-out-030-201612 | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor:
----------------------------------------------+----------------------------
Comment (by chelseakomlo):
I think this ticket can be closed with only documentation changes. Other
larger todos, such as fixing Chutney flakiness and incorporating Chutney
into the Jenkins pipeline, are captured in tickets mentioned above.
Replying to [comment:12 teor]:
> I suggest you split this ticket into a subticket for each set of
changes.
> * Your changes to the tor documentation could be reviewed by any of the
current developers, or just given straight to nickm.
See documentation changes at
`git at github.com:chelseakomlo/tor_patches.git`, branch
`documentation_integ_tests.` This adds the recommendation to run
integration tests before submitting code patches. It also recommends
running `make distcheck,` per cypherpunks feedback above.
> * Your changes to jenkins and docker are best reviewed by people
familiar with them - I'm not sure who that is, but weasel does admin our
jenkins instances.
Great, I opened tickets for these & weasel reviewed. Docker doesn't make
sense for the Jenkins pipeline, but the PoC is translatable to the work
required to set up a task to run chutney on every build.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list