[tor-bugs] #21026 [Core Tor/Tor]: Remove the abort handler in the backtrace generator

[Tor Bug Tracker & Wiki]

#21026: Remove the abort handler in the backtrace generator
------------------------------+------------------------------
     Reporter:  cypherpunks   |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 The
 [https://gitweb.torproject.org/tor.git/tree/src/test/test_bt_cl.c?id=51ee549a90e3e1b6c87f4ac588ac9fed51f0cc27#n79
 abort handler] in the backtrace generator calls `exit(3)` which is not
 asynchronous-signal-safe. Calling `exit(3)` in this context is undefined
 behavior according to the C standard. See
 https://www.securecoding.cert.org/confluence/x/34At for more information.

 FWICT the handler is meant to force the backtrace generator to always have
 an zero exit code. How the generator is currently used its exit code does
 not matter so the handler can probably be removed.

 Patch coming soon after some testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21026>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online