[tor-bugs] #20920 [Core Tor/Tor]: Lower MAX_SAMPLE_THRESHOLD by a lot

[Tor Bug Tracker & Wiki]

#20920: Lower MAX_SAMPLE_THRESHOLD by a lot
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #19877        |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 I wonder if the fractional restriction is any useful now that we have the
 absolute restriction. In most cases the absolute restriction will take
 priority over fractional restriction (20% of total guards is like 110
 guards right now).

 I feel like the absolute restriction is more accurate and powerful. Maybe
 we can kill the fractional one to reduce code?

 Perhaps it would make sense to introduce the fractional restriction if it
 was based on guard bandwidth and not just number of guards.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20920#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online