[tor-bugs] #20572 [Core Tor/Tor]: hs: Remove the private key material from hs_descriptor.h

[Tor Bug Tracker & Wiki]

#20572: hs: Remove the private key material from hs_descriptor.h
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:  jryans
     Type:  defect                              |         Status:
                                                |  needs_review
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612  |  Actual Points:
Parent ID:                                      |         Points:  0.5
 Reviewer:                                      |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by jryans):

 * status:  assigned => needs_review


Comment:

 Branch available at https://github.com/jryans/tor/commits/hs-rm-private-
 key.

 `hs_desc_encode_descriptor` takes a new arg for the signing keypair so
 signing the descriptor can still be done (from tests, etc).  Not sure if
 it's okay to expose `ed25519_keypair_t` at this level, since it could be
 v3 specific, but perhaps that can be revised in follow up work.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20572#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online