[tor-bugs] #20906 [Core Tor/Tor]: SocksPorts and ControlPorts should be stored in a set, not a list

[Tor Bug Tracker & Wiki]

#20906: SocksPorts and ControlPorts should be stored in a set, not a list
-----------------------------+------------------------------------
 Reporter:  arthuredelstein  |          Owner:
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tbb-wants        |  Actual Points:
Parent ID:                   |         Points:  0.2
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:4 dgoulet]:
 > Ok, once we've parsed a port, we need to validate if it's already in the
 list. Moving to a set might require quite the patch but validating that we
 have a duplicate in the list could be shorter path.
 >
 > Putting this one in 030 but it could be differed if we are a bit
 overwhelmed by the amount of things that goes in 030. What is the
 consequence of differing to 031 for TBB?

 The main thing is that we are backing off using domain sockets by default
 (#20761) until this issue is fixed. I thing we'll want to be using domain
 sockets by default in TBB 7.0-stable, which comes out no later than
 2017-06-13 (hopefully earlier).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20906#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online