[tor-bugs] #19877 [Core Tor/Tor]: Implement new guard selection algorithm of prop 271

[Tor Bug Tracker & Wiki]

#19877: Implement new guard selection algorithm of prop 271
-------------------------------------------------+-------------------------
 Reporter:  andrea                               |          Owner:  nickm
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  isaremoved, nickwants029, tor-       |  Actual Points:
  guards-revamp, TorCoreTeam201611, review-      |
  group-13                                       |
Parent ID:                                       |         Points:
 Reviewer:  chelseakomlo, asn                    |        Sponsor:
                                                 |  SponsorU-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hello,

 I did some initial testing and a first pass of manual code review.

 You can see the first testing results here:
 https://trac.torproject.org/projects/tor/wiki/doc/NewGuardAlgorithmTesting

 I also left a few comments on the gitlab review with things that should be
 discussed. Some of those comments might be follow-up material (#20822).

 Also, please check my `prop271_030_v1` branch for some misc fixes.

 BTW, starting tomorrow and until Monday I will be travelling and will have
 reduced connectivity and time for review. I might manage to do a few
 stuff, but I will continue in full force starting next Tuesday. Next week
 I can do more testing, and also some refactoring, and perhaps add some
 unittests (e.g. for the flappiness feature).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19877#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online