[tor-bugs] #20572 [Core Tor/Tor]: hs: Remove the private key material from hs_descriptor.h

[Tor Bug Tracker & Wiki]

#20572: hs: Remove the private key material from hs_descriptor.h
------------------------------------------------+--------------------------
 Reporter:  dgoulet                             |          Owner:
     Type:  defect                              |         Status:  new
 Priority:  High                                |      Milestone:  Tor:
                                                |  0.3.0.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612  |  Actual Points:
Parent ID:                                      |         Points:  0.5
 Reviewer:                                      |        Sponsor:
                                                |  SponsorR-must
------------------------------------------------+--------------------------
Changes (by dgoulet):

 * keywords:  tor-hs, prop224, TorCoreTeam201611 => tor-hs, prop224,
     TorCoreTeam201612


Comment:

 Replying to [comment:2 jryans]:
 > I'd like to make an attempt here, assuming that's okay.

 Great thanks for this jryans!

 > It appears the private key from `signing_kp` is used to sign the
 descriptor in `desc_encode_v3`, so if the private key is removed from
 `hs_desc_plaintext_data_t`, is there a specific place it should be moved
 so that signing can still happen?

 No for now, the secret key material will go in data structure that are
 being designed/implemented (from #20657) so they should be removed from
 the current HS descriptor code and it should only manage public key
 material.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20572#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online