[tor-bugs] #20352 [Applications/Tor Browser]: Integrate sandboxed Tor Browser into our gitian build system

[Tor Bug Tracker & Wiki]

#20352: Integrate sandboxed Tor Browser into our gitian build system
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-gitian, tbb-sandboxing,          |  Actual Points:
  GeorgKoppen201611, TorBrowserTeam201612R       |
Parent ID:  #19750                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:28 gk]:

 >
 > Okay. boklm: I have bug_20352 (https://gitweb.torproject.org/user/gk
 /gitian-
 builder.git/commit/?h=bug_20352&id=eab8568ddcb3c4ea8b7b1d8b6321946f68b2f10e)
 in my gitian-builder repo enabling backports. It seems that might not be
 enough, though, as one has to request using backports for a package
 explicitely (IIRC). I try to test that later but my build/test machine is
 currently occupied with other high prio stuff. If you could give that a
 whirl that would be great.

 I added a patch for gitian-builder.git, adding support for a
 `backports_packages` option in the descriptiors (in addition to your patch
 enabling the repository):
 https://trac.torproject.org/projects/tor/attachment/ticket/20352/0001-Bug-20352
 -add-option-to-install-backports-packages.patch

 After making this change to `gitian-sandbox.yml`, the `libseccomp-dev` and
 `libseccomp2` packages are now installed from backports:
 {{{
 diff --git a/gitian/descriptors/linux/gitian-sandbox.yml
 b/gitian/descriptors/linux/gitian-sandbox.yml
 index 70b9902..71910c2 100644
 --- a/gitian/descriptors/linux/gitian-sandbox.yml
 +++ b/gitian/descriptors/linux/gitian-sandbox.yml
 @@ -13,9 +13,10 @@ packages:
  # Needed for the sandboxing code
  - "libx11-dev"
  - "pkg-config"
 -- "libseccomp-dev"
 -- "libseccomp2"
  - "libgtk-3-dev"
 +backports_packages:
 +  - "libseccomp-dev"
 +  - "libseccomp2"
  reference_datetime: "2000-01-01 00:00:00"
  remotes:
  - "url": "https://github.com/pkg/error"
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20352#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online