[tor-bugs] #20492 [Core Tor/Tor]: Tor git version is not generated in git worktrees

Mon Dec 5 03:33:33 UTC 2016

#20492: Tor git version is not generated in git worktrees
--------------------------+------------------------------
 Reporter:  teor          |          Owner:  jryans
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  log, easy     |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------
Changes (by jryans):

 * status:  assigned => needs_review


Comment:

 As suggested in comment 5, we only need to check that .git exists.  I used
 -r to check that it's readable, which works for both a regular git repo
 and a worktree (verified both cases locally).

 https://github.com/jryans/tor/commits/git-worktree-rev

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20492#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online