[tor-bugs] #19376 [Core Tor/Torsocks]: Fix a few torsocks bugs caused by unquoted variables

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Dec 3 11:00:53 UTC 2016


#19376: Fix a few torsocks bugs caused by unquoted variables
-------------------------------+--------------------------------
 Reporter:  cypherpunks        |          Owner:  dgoulet
     Type:  defect             |         Status:  needs_revision
 Priority:  Medium             |      Milestone:
Component:  Core Tor/Torsocks  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+--------------------------------

Comment (by cypherpunks):

 Replying to [comment:4 dgoulet]:
 > I can't apply this patch. Can you send me a git diff or a branch or git
 format-patch? The diff file assume that torsocks is in `/usr/bin/torsocks`
 and thus fails :S ... If you can't let me know, I'll apply it by hand but
 I would rather not.

 Even after all this time, the script is just as horrifying. It's
 reminiscent of reading glibc. Not as traumatic though, it's a lot shorter.

 Since the bug is still present in 2.2.0 (and I had forgot about this bug),
 I wrote a quick new one in git diff format. The new patch assumes it's in
 src/bin/torsocks (where it is in the source tgz).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19376#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list