[tor-bugs] #20864 [Core Tor/Tor]: Minor fixes to test_single_onion_poisoning

[Tor Bug Tracker & Wiki]

#20864: Minor fixes to test_single_onion_poisoning
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: unspecified
     Severity:  Normal        |   Keywords:  hs
Actual Points:  0.1           |  Parent ID:
       Points:  0.1           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 When I wrote #20638, the unit test had some subtle bugs:
 * a missed return value check in a unit test,
 * a double-free (well, two double-frees),
 * an inconsistent allocation-free construction that would be easy to break
 in future.

 I also want to move a comment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20864>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online