[tor-bugs] #20715 [Core Tor/Tor]: memory leak in tor_cert_parse()

[Tor Bug Tracker & Wiki]

#20715: memory leak in tor_cert_parse()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.5-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  028-backport  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * keywords:   => 028-backport


Comment:

 Hi, neel!  That won't work actually, since the `dest` pointer there can be
 a pointer to the inside of another allocation.  (There are several
 structures that have signed_descriptor_t included in them.)

 Maybe we should just copy the part that clears the relevant parts of the
 dest structure?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20715#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online