[tor-bugs] #20037 [Metrics/CollecTor]: Add support for Bifroest's bridge descriptor tarballs
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Aug 31 19:34:08 UTC 2016
#20037: Add support for Bifroest's bridge descriptor tarballs
-------------------------------+------------------------------
Reporter: karsten | Owner:
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Comment (by iwakeh):
Replying to [comment:3 karsten]:
> We won't have time to add tests before deploying, because, erm, it's
deployed as of 60 minutes ago. And I guess I should push what I'm
running, in particular as it didn't break. Unless I shouldn't?!
>
Well, if its running it should be committed, so we know what is running.
Not breaking doesn't necessarily mean 'working as expected' to me. (I hope
it does here.)
> But we can always add more tests going forward. How about we do that
together with the other bridgedescs module tests that I wrote on some
other ticket?
Yes, that would be very good and sort of the only type of documentation
for that code.
Of course, the code itself tells something, but often it does not exactly
what was expected by the author. These tests will also reduce maintenance
time a lot in future.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20037#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list