[tor-bugs] #15852 [Applications/Tor Browser]: Remove/synchronize Torbutton SOCKS pref logic

[Tor Bug Tracker & Wiki]

#15852: Remove/synchronize Torbutton SOCKS pref logic
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-4.5-regression, tbb-torbutton-   |  Actual Points:
  conversion, TorBrowserTeam201608R              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  reopened => needs_review


Comment:

 While testing some other things, Kathy and I noticed a change in behavior
 compared to older versions of Torbutton: prior to the commit that fixed
 this ticket, the network.proxy.socks and network.proxy.socks_port prefs
 were not reset in the absence of env vars. We should probably restore the
 old behavior.

 Here is a fixup patch:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug15852-03&id=1648da8461dfed9975ac83fdb03aa745b6c8d49b

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online