[tor-bugs] #15852 [Applications/Tor Browser]: Remove/synchronize Torbutton SOCKS pref logic

[Tor Bug Tracker & Wiki]

#15852: Remove/synchronize Torbutton SOCKS pref logic
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-4.5-regression, tbb-torbutton-   |  Actual Points:
  conversion, TorBrowserTeam201608R              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:13 mcs]:
 > Replying to [comment:12 gk]:
 > > 3) I have the feeling that
 > > {{{
 > > // XXX: Hack for TBB people who alternate between transproxy and non
 > > }}}
 > > in `startup-observer.js` can go as well or did I miss something?
 > Do you mean just remove the comment or do you want the code to be
 removed? Kathy and I thought we should keep the code so that existing
 behavior is not modified for users who rely on setting the env variables.

 Just the comment. It seemed to me, if at all, then it only applied to the
 lines you removed.

 > Thanks for reviewing all of this!

 Sure. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online