[tor-bugs] #19953 [Core Tor]: DataDirectoryGroupReadable does not take effect when relay enabled

[Tor Bug Tracker & Wiki]

#19953: DataDirectoryGroupReadable does not take effect when relay enabled
--------------------------+--------------------------
     Reporter:  redfish   |      Owner:
         Type:  defect    |     Status:  new
     Priority:  Medium    |  Milestone:
    Component:  Core Tor  |    Version:  Tor: 0.2.8.6
     Severity:  Normal    |   Keywords:
Actual Points:            |  Parent ID:
       Points:            |   Reviewer:
      Sponsor:            |
--------------------------+--------------------------
 Add 'DataDirectoryGroupReadable 1'
 Permissions on /var/lib/tor are as expected: 0750

 Now, uncomment 'ORPort 9001':
 Permissions on /var/lib/tor briefly switch to 0750 but then back to 0700,
 despite DataDirectoryGroupReadable being still set to 1.

 The patch for Ticket #17562 that adds DataDirectoryGroupReadable option
 did not change all calls to check_private_dir:
 https://trac.torproject.org/projects/tor/attachment/ticket/17562/0002
 -Introduce-DataDirectoryGroupReadable-boolean.patch

 Patch that fixes the issue is attached to this ticket. But, ideally,
 should factor the check for data dir into a function, but I figured a dev
 can do that instead of me dabbling with the code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19953>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online