[tor-bugs] #13953 [Core Tor/Tor]: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument

[Tor Bug Tracker & Wiki]

#13953: Self-test reachability test - Listen address from ORPort is ignored, it
uses default address unless specified via Address argument
-----------------------------------------------+---------------------------
 Reporter:  s7r                                |          Owner:  teor
     Type:  enhancement                        |         Status:
                                               |  merge_ready
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.2.5.10
 Severity:  Normal                             |     Resolution:
 Keywords:  review-group-7, TorCoreTeam201608  |  Actual Points:  0.5
Parent ID:  #17782                             |         Points:  3
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by teor):

 * keywords:  review-group-7 => review-group-7, TorCoreTeam201608
 * status:  needs_revision => merge_ready


Comment:

 (Some people don't have github, so it's hard for us to swap pull requests
 on Trac.)

 The latest branch is:
 bug13953 on ​https://github.com/gits7r/tor.git

 On review, here's some things we could change:
 * make the log message a `static const char *` with "ORPort" and "DirPort"
 replaced with "%sPort"
 * the OR and Dir code is almost identical - we could put it in its own
 function to avoid duplication, and pass the inputs as parameters
 * add a unit test

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13953#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online